Skip to content

[ENH] Wire up collection forking for RFE #4309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 22, 2025
Merged

[ENH] Wire up collection forking for RFE #4309

merged 4 commits into from
Apr 22, 2025
+343 −42

Conversation

Sicheng-Pan
Copy link
Contributor

@Sicheng-Pan Sicheng-Pan commented Apr 17, 2025 •
edited
Loading

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • N/A
  • New functionality
    • Wires up collection forking for RFE

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

@github-actions GitHub Actions
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@Sicheng-Pan Sicheng-Pan mentioned this pull request Apr 17, 2025
Merged
1 task
@Sicheng-Pan Graphite App
Copy link
Contributor Author

Sicheng-Pan commented Apr 17, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Sicheng-Pan Sicheng-Pan mentioned this pull request Apr 17, 2025
Merged
1 task
@Sicheng-Pan Sicheng-Pan marked this pull request as ready for review April 17, 2025 20:35
@Sicheng-Pan Sicheng-Pan changed the title [ENH] Wire up collection forking for client [ENH] Wire up collection forking for server and clien Apr 17, 2025
@Sicheng-Pan Sicheng-Pan changed the title [ENH] Wire up collection forking for server and clien [ENH] Wire up collection forking for RFE Apr 17, 2025
@Sicheng-Pan Sicheng-Pan force-pushed the sicheng/04-17-_enh_wire_up_collection_forking_for_client branch from d1cae52 to fa7bbc5 Compare April 17, 2025 23:27
@Sicheng-Pan Sicheng-Pan force-pushed the sicheng/04-16-_enh_implement_collection_forking_in_sysdb branch from d0c2664 to ef49022 Compare April 17, 2025 23:27
@Sicheng-Pan Sicheng-Pan mentioned this pull request Apr 18, 2025
Merged
1 task
@Sicheng-Pan Sicheng-Pan force-pushed the sicheng/04-17-_enh_wire_up_collection_forking_for_client branch 2 times, most recently from 59b6c06 to b6216a2 Compare April 18, 2025 20:06
@Sicheng-Pan Sicheng-Pan force-pushed the sicheng/04-16-_enh_implement_collection_forking_in_sysdb branch from e6cd434 to 1305109 Compare April 18, 2025 21:13
@Sicheng-Pan Sicheng-Pan force-pushed the sicheng/04-17-_enh_wire_up_collection_forking_for_client branch 2 times, most recently from d74eeb7 to 1d7c5a0 Compare April 18, 2025 21:21
@Sicheng-Pan Sicheng-Pan mentioned this pull request Apr 18, 2025
Merged
1 task
@Sicheng-Pan Sicheng-Pan force-pushed the sicheng/04-17-_enh_wire_up_collection_forking_for_client branch from 1d7c5a0 to 8c8ee82 Compare April 21, 2025 17:25
@Sicheng-Pan Sicheng-Pan force-pushed the sicheng/04-16-_enh_implement_collection_forking_in_sysdb branch from f793381 to 2559947 Compare April 21, 2025 17:25
@Sicheng-Pan Sicheng-Pan force-pushed the sicheng/04-17-_enh_wire_up_collection_forking_for_client branch 2 times, most recently from 4f173c7 to 6adb2bc Compare April 21, 2025 18:24
@Sicheng-Pan Sicheng-Pan force-pushed the sicheng/04-16-_enh_implement_collection_forking_in_sysdb branch from d5d63af to 993e103 Compare April 22, 2025 18:25
@Sicheng-Pan Sicheng-Pan force-pushed the sicheng/04-17-_enh_wire_up_collection_forking_for_client branch from 6adb2bc to 73360ef Compare April 22, 2025 18:25
@Sicheng-Pan Sicheng-Pan force-pushed the sicheng/04-16-_enh_implement_collection_forking_in_sysdb branch from 993e103 to 34c3dbf Compare April 22, 2025 20:21
@Sicheng-Pan Sicheng-Pan force-pushed the sicheng/04-17-_enh_wire_up_collection_forking_for_client branch from 73360ef to 9920079 Compare April 22, 2025 20:21
@Sicheng-Pan Sicheng-Pan force-pushed the sicheng/04-17-_enh_wire_up_collection_forking_for_client branch from 9920079 to 8bdce24 Compare April 22, 2025 21:44
@Sicheng-Pan Sicheng-Pan force-pushed the sicheng/04-16-_enh_implement_collection_forking_in_sysdb branch 2 times, most recently from 507a6e3 to b68e9da Compare April 22, 2025 21:52
@Sicheng-Pan Sicheng-Pan force-pushed the sicheng/04-17-_enh_wire_up_collection_forking_for_client branch from 8bdce24 to e57601e Compare April 22, 2025 21:52
@Sicheng-Pan Graphite App
Copy link
Contributor Author

Sicheng-Pan commented Apr 22, 2025 •
edited
Loading

Merge activity

  • Apr 22, 7:04 PM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Apr 22, 7:06 PM EDT: Graphite rebased this pull request as part of a merge.
  • Apr 22, 7:06 PM EDT: A user merged this pull request with Graphite.

@Sicheng-Pan Sicheng-Pan changed the base branch from sicheng/04-16-_enh_implement_collection_forking_in_sysdb to graphite-base/4309 April 22, 2025 23:04
@Sicheng-Pan Sicheng-Pan changed the base branch from graphite-base/4309 to main April 22, 2025 23:04
@Sicheng-Pan Sicheng-Pan force-pushed the sicheng/04-17-_enh_wire_up_collection_forking_for_client branch from e57601e to 8a42695 Compare April 22, 2025 23:05
@Sicheng-Pan Sicheng-Pan merged commit fc8ce7b into main Apr 22, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanketkedia sanketkedia sanketkedia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sicheng-Pan @sanketkedia